Match.run() fix, add tests, parses bestmove's info - #13
Merged
Conversation
fox for iamjarret#8 pv was left as string, as I'm unsure what form is more appropriate on the way: -additions to docstrings (Match.move, Engine.bestmove, Engine._movelisttostr) -used shorthand notation for _movelisttostr concatenation, ponder assignment in Match.move
pafnucy
changed the title
iamjarret
approved these changes
Nov 23, 2016
iamjarret
left a comment
iamjarret
left a comment
Owner
There was a problem hiding this comment.
These are high-quality changes. Thanks for your wonderful contribution, Andrew!
Contributor
Author
This was referenced Apr 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12
Didn't experiment with ponder, but I think it should be fine in proposed setup. I changed order of code, so break in the move loop occurs when there is mate, no matter what is value of ponder.
If you have any ideas for further testing, please share.